Skip to content

fix: parse datetime with zero year #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix: parse datetime with zero year #1367

wants to merge 2 commits into from

Conversation

dundee
Copy link

@dundee dundee commented Nov 2, 2022 •
edited
Loading

Description

MySQL supports datetimes with zero year (e.g. 0000-01-01 00:00:00). Other libraries parse it and return it correctly, we should too.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@methane
Copy link
Member

methane commented Nov 10, 2022

Is this duplicate of #1257 ?

@dundee
Copy link
Author

dundee commented Nov 10, 2022

Yes, this issue is solved by merging #1257. We might use the additional test case added here though.

@dundee dundee closed this Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dundee @methane